don't close connection in management command #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
close_old_connections()
at the end of the management command, because this prevents usingcall_command
in the context of tests :This fails with
psycopg2.InterfaceError: connection already closed
, as tests are run in transaction and django needs to rollback the transaction at the end of the test.The
close_old_connections()
line was added in f7de420 back in 2013, I'm pretty sure in the mean time it's become useless.